RFR: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:" [v3]

Jaikiran Pai jpai at openjdk.java.net
Thu Oct 14 03:25:07 UTC 2021


> The commit here tries to address an intermittent failure reported in https://bugs.openjdk.java.net/browse/JDK-8254267.
> 
> The `LogParameters` test case sets the log level to `ALL` for the `java.lang.String.class` and then attaches a handler to it. It then proceeds to write out a log message at `DEBUG` level and expects the log message to have been delivered to the handler.  This should all work fine and does work fine except for those intermittent failures.
> 
> Looking at the output attached in that JBS issue, there's this:
> 
> 
> command: main LogParameters
> reason: Assumed action based on file name: run main LogParameters
> Mode: agentvm 
> 
> which states that the test is using `agentvm` mode, since the test itself doesn't specify a specific mode. For a test like this one which deals with log level management of `java.util.logging` infrastructure, in theory, there are chances that some other tests within the same JVM instance might impact the output and can potentially contribute to intermittent failures like this one.
> 
> The commit in this PR tries to address that issue by explicitly running the test in `othervm` mode.
> 
> P.S: Every once in a while my logins to JBS don't work and if I just wait for a few hours, things get sorted on its own. Today is one such occasion - successful login, but it still shows me as logged out and doesn't allow me to do anything. So I decided to directly create this PR instead of first commenting there.

Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:

 - add a summary to the test as well as use a different logger than String.class to avoid any confusion
 - hold on to the logger instance

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5927/files
  - new: https://git.openjdk.java.net/jdk/pull/5927/files/2213629b..c4371826

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5927&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5927&range=01-02

  Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5927.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5927/head:pull/5927

PR: https://git.openjdk.java.net/jdk/pull/5927



More information about the security-dev mailing list