RFR: 8272163: Add -version option to keytool and jarsigner [v2]

Hai-May Chao hchao at openjdk.java.net
Tue Oct 19 06:16:26 UTC 2021


On Tue, 19 Oct 2021 03:40:55 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix -version in jarsigner and update tests
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 314:
> 
>> 312:         if (version) {
>> 313:             doPrintVersion();
>> 314:         }
> 
> So if both `-version` and `file.jar` are provided, jarsigner will both sign the jar and print the version. This is probably OK but I prefer the `java` style that only prints the version.

Ok, change made to have jarsigner to only print the version and ignore other options.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5954


More information about the security-dev mailing list