RFR: 8158689: java.security.KeyPair should implement Destroyable

[Anthony Scarpino]

On Fri, 22 Oct 2021 23:50:38 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> Hi,
> 
> I need a review of this change.  It makes KeyPair implement Destroyable and implements the methods to call the underlying privateKey.  It also sets the public and private key to 'final'.
> 
> The bug includes a CSR and Release Notes
> CSR: https://bugs.openjdk.java.net/browse/JDK-8275823
> RN: https://bugs.openjdk.java.net/browse/JDK-8275826

Even though it has been the only option for a long time, calling `keyPair.getPrivateKey().destory()` is not clean and one should not have had to go into a class's objects to cleanup.   It's reminiscent of free memory in C.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6089