RFR: 8231107: Allow store password to be null when saving a PKCS12 KeyStore

[Sean Mullan]

On Mon, 25 Oct 2021 23:44:18 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> test/jdk/sun/security/pkcs12/EmptyPassword.java line 27:
>> 
>>> 25:  * @test
>>> 26:  * @bug 8202299 8231107
>>> 27:  * @modules java.base/sun.security.tools.keytool
>> 
>> Can you add an @summary?
>
> I'll update the existing summary to `@summary Testing empty (null, "", "\0") password behaviors`.

Ok.

>> test/jdk/sun/security/pkcs12/EmptyPassword.java line 57:
>> 
>>> 55:                 });
>>> 56: 
>>> 57:         // 8202299: interop before new char[0] and new char[1]
>> 
>> Can you make this comment more descriptive? Not sure what "before" means. Is this just making sure you can store a keystore and key entry with "\0" as the password and load it back with ""? Should you also try to load it back with "\0" too?
>
> Typo: s/before/between/.
> 
> I'll add one with "\0". That should always work since it's the same password used in load() and store().

Ok.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5950