RFR: 8273026: Slow LoginContext.login() on multi threading application [v2]
Larry-N
duke at openjdk.java.net
Wed Oct 27 13:06:57 UTC 2021
On Wed, 27 Oct 2021 12:56:41 GMT, Larry-N <duke at openjdk.java.net> wrote:
>> This fix adds a cache of service provider classes to LoginContext (in particular, it's a cache of LoginModules classes). The approach helps to increase the performance of the LoginContext.login() method significantly, especially in a multi-threading environment. Service Loader is used for polling on Service Provider classes, without instantiating LoginModules object if Service Provider name doesn't match record in .config file. The set of service providers is cached for each Context Loader separately.
>> This code passed successfully tier1 and tier2 tests on mac os.
>
> Larry-N has updated the pull request incrementally with one additional commit since the last revision:
>
> 1. Address JCK failure 2.Address review notes
@wangweij With the new commit, I've moved filling ServiceProviders cache filling to login() method. And addressed your notice about correction for spi/Loader.java test. Could you please take a look when you have a chance? Thank you.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5748
More information about the security-dev
mailing list