RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v9]

[Aleksei Efimov]

On Wed, 27 Oct 2021 16:23:29 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add @ throws NPE to hosts file resolver javadoc
>
> src/java.base/share/classes/java/net/InetAddress.java line 841:
> 
>> 839:         // 'resolver.lookupByAddress' and 'InetAddress.getAllByName0' delegate to the system-wide resolver,
>> 840:         // which could be a custom one. At that point we treat any unexpected RuntimeException thrown by
>> 841:         // the resolver as we would treat an UnknownHostException or an unmatched host name.
> 
> indentation issue in comment above

Thanks - moved the comment block inside `catch` block (f660cc6ecc7a31c83de220160b9fd8d0fbacd1be)

> src/java.base/share/classes/java/net/InetAddress.java line 1308:
> 
>> 1306:      * Creates an InetAddress based on the provided host name and IP address.
>> 1307:      * System {@linkplain InetAddressResolver resolver} is not used to check
>> 1308:      * the validity of the address.
> 
> Is this term "system resolver" defined somewhere? I think it means the configured resolver for the current VM. Previously, it really was the system resolver. So, I think it's potentially confusing, as there is also reference to the java.net.preferIPv6Addresses system property as having a possible value "system" which refers to the operating system. Since the CSR is approved, I'm happy to discuss this point post integration.

Thanks for highlighting that: Changed `"system"` to `"the system-wide"` - that's what was originally meant by `"system resolver"` (f660cc6ecc7a31c83de220160b9fd8d0fbacd1be).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5822