RFR: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

Rajan Halade rhalade at openjdk.java.net
Tue Sep 7 14:36:38 UTC 2021


On Thu, 2 Sep 2021 13:33:30 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

> This trivial change fixes the case 2 in test sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec, the method testKeySpec is expecting a class object of type KeySpec as second argument in order to be reusable for multiple test scenarios, but then instead of using that argument the RSAPrivateKeySpec.class is hardcoded:
> 
> 
> private static void testKeySpec(KeyFactory factory, PrivateKey key, Class<? extends KeySpec> specClass) throws Exception {
>         try {
>             KeySpec spec = factory.getKeySpec(key, RSAPrivateKeySpec.class);
> 
> 
> it should be:
> 
> `KeySpec spec = factory.getKeySpec(key, specClass);
> `

Marked as reviewed by rhalade (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5351



More information about the security-dev mailing list