RFR: 8273401: Remove JarIndex support in URLClassPath

Lance Andersen lancea at openjdk.java.net
Tue Sep 7 16:33:36 UTC 2021

On Tue, 7 Sep 2021 03:34:27 GMT, wxiang <github.com+53162078+shiyuexw at openjdk.org> wrote:

> There is a bug for URLClassPath.findResources with JarIndex.
> With some discussions about the bug, the current priority is to remove the JAR index support in URLClassPath, 
> and don’t need to do anything to the jar tool in the short term, except just to move JarIndex to the jdk.jartool module. 
> The PR includes:
> 1. remove the JarIndex support in URLClassPath
> 2. move JarIndex into  jdk.jartool module.

I think this looks good overall.

Once you do your next set up updates, I will run it through mach5 for you

src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 73:

> 71: import static java.util.jar.JarFile.MANIFEST_NAME;
> 72: import static java.util.stream.Collectors.joining;
> 73: import static java.util.jar.JarFile.INDEX_NAME;

Maybe move this above the java.util.streamCollectors.joining import

Also, the copyright should probably be updated to 2021

test/jdk/sun/misc/JarIndex/JarIndexMergeTest.java line 25:

> 23: 
> 24: /*
> 25:  * @test

Probably should update the copyright year to include 2021


PR: https://git.openjdk.java.net/jdk/pull/5383

More information about the security-dev mailing list