RFR: 8274075: Fix miscellaneous typos in java.base [v2]
Pavel Rappo
prappo at openjdk.java.net
Wed Sep 22 10:27:09 UTC 2021
On Tue, 21 Sep 2021 22:00:29 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Instead of "common case where a wrapped exception is thrown from same method" could one write "common case where an enclosing exception is thrown from the same method"?
>
> Note that we don't throw the "wrapped exception" we throw the exception that wraps it. The "wrapped exception" is the original cause. The wording as presented now is correct in that regard. You could also say "Throwing a wrapper exception (i.e. one that has a cause)" - I think both are grammatically correct.
>
> The later text "where a wrapped exception is thrown from the same method" is again incorrect because the wrapped exception (the cause) is not what gets thrown. But I find that whole sentence rather jarring anyway - I'm not certain exactly what it means.
I'm inclined to revert this change on Throwable.java:68, because of the lack of consensus. It clearly is not a simple typo.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5610
More information about the security-dev
mailing list