RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

Thu Sep 30 04:48:38 UTC 2021

On Thu, 30 Sep 2021 01:22:56 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

> See comment, + a couple minor cleanups.

src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java line 153:

> 151:         private final byte[] label;
> 152: 
> 153:         SecretSchedule(String label) {

Why are we opening the visibility on this enum?  As far as I can tell it is only ever referenced within the SSLSecretDerivation class and could remain private if it hasn't been causing any problems up to now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5765