RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs [v3]

Joe Darcy darcy at openjdk.java.net
Thu Sep 30 17:43:12 UTC 2021


> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial checking are out for review (#5709) and various security libraries would need some changes to pass under the expanded checks.
> 
> The changes are to suppress warnings where non-transient fields in serializable types are not declared with a type statically known to be serializable. That isn't necessarily a correctness issues, but it does merit further scrutiny.

Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Update copyrigths.
 - Merge branch 'master' into JDK-8274393
 - Add explanatory comments for SuppressWarnings annotations.
 - Merge branch 'master' into JDK-8274393
 - 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5720/files
  - new: https://git.openjdk.java.net/jdk/pull/5720/files/08718270..dcb48a0a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5720&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5720&range=01-02

  Stats: 815 lines in 52 files changed: 604 ins; 55 del; 156 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5720.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5720/head:pull/5720

PR: https://git.openjdk.java.net/jdk/pull/5720



More information about the security-dev mailing list