RFR: 8284415: Collapse identical catch branches in security libs

Mike StJohns mstjohns at comcast.net
Wed Apr 6 17:43:03 UTC 2022


Before you approve this, why would you rethrow just the message rather than the actual original cause? Seems like you’re losing debug info including the type of the original exception for no good reason.

Mike

Sent from my iPad

> On Apr 6, 2022, at 11:26, Xue-Lei Andrew Fan <xuelei at openjdk.java.net> wrote:
> 
> On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
> 
>> Let's take advantage of Java 7 language feature - "Catching Multiple Exception Types".
>> It simplifies code. Reduces duplication.
>> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try' statement`
> 
> Looks good to me.
> 
> -------------
> 
> Marked as reviewed by xuelei (Reviewer).
> 
> PR: https://git.openjdk.java.net/jdk/pull/8068



More information about the security-dev mailing list