RFR: 8284796: sun.security.ssl.Finished::toString misses a line feed in the message format pattern

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Wed Apr 13 06:11:12 UTC 2022


On Wed, 13 Apr 2022 05:10:22 GMT, John Jiang <jjiang at openjdk.org> wrote:

> The log for Finished message looks like the below,
> 
> "Finished": {
>   "verify data": {
>     0000: ... ...
>   }'}  // looks weird
> 
> because a line feed is missing in the format pattern.
> 
> ""Finished": '{'\n" +
> "  "verify data": '{'\n" +
> "{0}\n" +
> "  '}'" +  // a line feed is needed
> "'}'",

src/java.base/share/classes/sun/security/ssl/Finished.java line 150:

> 148:                     "{0}\n" +
> 149:                     "  '}'\n" +
> 150:                     "'}'",

As you are already here to touch the code, would you like to use text block instead?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8215



More information about the security-dev mailing list