RFR: JDK-8284112 Minor cleanup could be done in javax.crypto

Bradford Wetmore wetmore at openjdk.java.net
Wed Apr 13 06:37:06 UTC 2022


On Tue, 12 Apr 2022 21:59:09 GMT, Mark Powers <duke at openjdk.java.net> wrote:

> JDK-8284112 Minor cleanup could be done in javax.crypto

src/java.base/share/classes/javax/crypto/CipherInputStream.java line 159:

> 157:         try {
> 158:             ofinish = cipher.update(ibuffer, 0, readin, obuffer, ostart);
> 159:         } catch (IllegalStateException e) {

This is another one of those I would probably leave alone, just so it's clear what should be done.

src/java.base/share/classes/javax/crypto/CipherSpi.java line 29:

> 27: 
> 28: import java.nio.ByteBuffer;
> 29: import java.security.*;

This is another one that some people will complain about.  I personally prefer this style, others prefer everything written out as long as it's not "too many."

-------------

PR: https://git.openjdk.java.net/jdk/pull/8214



More information about the security-dev mailing list