RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

Sean Mullan mullan at openjdk.java.net
Wed Apr 13 15:39:19 UTC 2022


On Tue, 12 Apr 2022 01:27:35 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

> This trivial change is to deprecate the DEFAULT static field of OAEPParameterSpec class. Wordings are mostly the same as the previous PSSParameterSpec deprecation change. Rest are just minor code re-factoring.
> 
> The CSR will be filed once review is somewhat finished.
> 
> Thanks,
> Valerie

src/java.base/share/classes/javax/crypto/spec/OAEPParameterSpec.java line 81:

> 79:  *     parameters for mgf -- MGF1ParameterSpec.SHA1
> 80:  *     source of encoding input -- PSource.PSpecified.DEFAULT
> 81:  * </pre>

I think you should leave these lines in, so users can still see what the default parameters are. Nit, change:
"the OAEPParameterSpec.DEFAULT uses the following"
to:
"{@code OAEPParameterSpec.DEFAULT} uses the following default values:"

-------------

PR: https://git.openjdk.java.net/jdk/pull/8191



More information about the security-dev mailing list