RFR: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec

Sean Mullan mullan at openjdk.java.net
Wed Apr 13 18:37:15 UTC 2022


On Wed, 13 Apr 2022 18:28:33 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/OAEPParameterSpec.java line 81:
>> 
>>> 79:  *     parameters for mgf -- MGF1ParameterSpec.SHA1
>>> 80:  *     source of encoding input -- PSource.PSpecified.DEFAULT
>>> 81:  * </pre>
>> 
>> I think you should leave these lines in, so users can still see what the default parameters are. Nit, change:
>> "the OAEPParameterSpec.DEFAULT uses the following"
>> to:
>> "{@code OAEPParameterSpec.DEFAULT} uses the following default values:"
>
> Leaving this in meaning we may have to duplicate the new wordings for the field here. The default values are covered in the paragraph above where the ASN.1 structure for RSAES-OAEP-params is defined. I can move this down to the javadoc field description for the DEFAULT field.

Ok.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8191



More information about the security-dev mailing list