RFR: 8186958: Need method to create pre-sized HashMap [v21]
Bradford Wetmore
wetmore at openjdk.java.net
Thu Apr 14 19:58:48 UTC 2022
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess <duke at openjdk.java.net> wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
I learned something new about HashMap today...
I looked at java.security.cert and sun.security.* and that part LGTM.
That said, you need to check with @seanjmullan for the java.xml.crypto code. We try to keep the code in sync with the Apache code. As this is a new API, we probably can't push this kind of change to Apache as they need to support older releases.
src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java line 110:
> 108: int length = attributes.getLength();
> 109: Map<String, String> namespaceMap =
> 110: HashMap.newHashMap(length);
Please check these changes with @seanjmullan before integrating.
-------------
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7928
More information about the security-dev
mailing list