RFR: 8284893: Fix typos in java.base

Alan Bateman alanb at openjdk.java.net
Fri Apr 15 13:09:39 UTC 2022


On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") in the source code, but they were not local and I dared not change them. Someone braver than me might take a stab at it, perhaps..

I skimmed through the changes to src/java.base and they look okay except for the changes to 3rd party code that I think should be dropped from this patch.

src/java.base/share/native/libzip/zlib/inftrees.h line 65:

> 63:    1444, which is the sum of 852 for literal/length codes and 592 for distance
> 64:    codes.  These values were found by exhaustive searches using the program
> 65:    examples/enough.c found in the zlib distribution.  The arguments to that

This is 3rd party code so should be dropped from the patch as we want as few changes to this code has possible.

src/java.base/windows/native/libnio/ch/wepoll.c line 894:

> 892:      * error code when the once-callback returns FALSE. We return -1 here to
> 893:      * indicate that global initialization failed; the failing init function is
> 894:      * responsible for setting `errno` and calling `SetLastError()`. */

This is also 3rd party code so should be dropped from this patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250


More information about the security-dev mailing list