RFR: 8284855: Update needed to Cleaners added to jdk.crypto.cryptoki [v5]
Xue-Lei Andrew Fan
xuelei at openjdk.java.net
Sat Apr 16 05:31:40 UTC 2022
On Fri, 15 Apr 2022 17:51:43 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add a reference to the clean up method
>
> src/jdk.crypto.cryptoki/unix/native/libj2pkcs11/p11_md.c line 274:
>
>> 272: ModuleData *moduleData = jlong_to_ptr(ckpNativeData);
>> 273:
>> 274: if (moduleData != NULL) {
>
> The check should be (moduleData->hModule != NULL)? Same goes for the other p11_md.c file.
I think it is safer to add the check for 'hModule'.
- if (moduleData != NULL) {
+ if (moduleData != NULL && moduleData->hModule != NULL) {
-------------
PR: https://git.openjdk.java.net/jdk/pull/8248
More information about the security-dev
mailing list