RFR: 8284855: Update needed to Cleaners added to jdk.crypto.cryptoki [v3]
Xue-Lei Andrew Fan
xuelei at openjdk.java.net
Sat Apr 16 05:38:40 UTC 2022
On Fri, 15 Apr 2022 18:48:33 GMT, Brent Christian <bchristi at openjdk.org> wrote:
>>> CleanerFactory is in java.base module, and does not export to jdk.crypto.cryptoki module. I'm not sure if adding modules dependency is good or not.
>
> It seems fine to me to export the common Cleaner to `jdk.crypto.cryptoki`. It's already [exported for desktop and Panama](https://github.com/bchristi-git/jdk/blob/master/src/java.base/share/classes/module-info.java#L226), and I see that [com.sun.crypto.provider](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/com/sun/crypto/provider/DESKey.java#L84) already uses it.
There are several places that don't use CleanerFactory here and there. I may fill a new PR later for this purpose.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8248
More information about the security-dev
mailing list