RFR: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297 [v2]

Anthony Scarpino ascarpino at openjdk.java.net
Mon Apr 18 23:49:35 UTC 2022


On Mon, 18 Apr 2022 20:43:06 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> When input length provided to the intrinsic is 8192, only 7680 bytes are processed as the intrinsic operates on multiples of 768 bytes.
>> In implGCMCrypt(ByteBuffer src, ByteBuffer dst) method, 
>> dst.put(bout, 0, PARALLEL_LEN) statement caused the ciphertext mismatch as PARALLEL_LEN was set to 8192. 
>> Since the intrinsic only processed 7680 bytes, the rest output was incorrect.
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated copyright year

I reran the test on aarch64 and x64 using -Xcomp without failure, also repeating the failing test. Given the bug says it was intermittent I can never been 100% certain it is perfect, but looking at the aarch64, it is just looping on that data it is presented, not hardcoded for a particular amount of data like the x64 code.  That looping should work fine with the code change.
I think it's ready to go into the repo.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8280



More information about the security-dev mailing list