RFR: 8284490: Remove finalizer method in java.security.jgss [v5]
Daniel Fuchs
dfuchs at openjdk.java.net
Wed Apr 20 15:24:40 UTC 2022
On Wed, 20 Apr 2022 15:12:23 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:
>> Please review the update to remove finalizer method in the java.security.jgss module. It is one of the efforts to clean up the use of finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>
> Update to set context method
src/java.security.jgss/share/classes/sun/security/jgss/wrapper/NativeGSSContext.java line 378:
> 376: if (pContext != 0 && cleanable != null) {
> 377: cleanable.clean();
> 378: pContext = 0;
Here and below: should pContext be set to 0 before calling cleanable.clean() to make sure cleanable.clean() is not called twice? Also should there be some synchronized block?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8136
More information about the security-dev
mailing list