RFR: 8285389: EdDSA trimming zeros

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Sun Apr 24 15:57:38 UTC 2022


On Sun, 24 Apr 2022 15:34:23 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> > Did you want to correct the verify testing so that it could
> > accept trimmed signature?  Or do not trimming the extra zeros
> > of the signature any longer?  I did not get the point from the
> > patch.
> 
> The test is correct. Perhaps a clear explanation is if the signature length is greater or less than expected an exception should be thrown for the length being wrong instead of trying to verify the signature. 

I like this explanation more.  I have no more comment about the patch.  Please add a noreg label in JBS.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8372



More information about the security-dev mailing list