RFR: 8285516: clearPassword should be called in a finally try block [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Mon Apr 25 14:23:17 UTC 2022


> Hi,
> 
> Could I have the simple update reviewed?
> 
> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() should be called in a finally try block.  Otherwise, the password cleanup could be interrupted by exceptions.
> 
> Thanks,
> Xuelei

Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:

  an extra whitespace added

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8377/files
  - new: https://git.openjdk.java.net/jdk/pull/8377/files/123374d1..99079d30

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8377&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8377&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8377.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8377/head:pull/8377

PR: https://git.openjdk.java.net/jdk/pull/8377



More information about the security-dev mailing list