RFR: 8284490: Remove finalizer method in java.security.jgss [v8]
Weijun Wang
weijun at openjdk.java.net
Tue Apr 26 02:08:02 UTC 2022
On Tue, 26 Apr 2022 02:01:10 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge and resovle merge conflict
>> - change the calling order in dispose()
>> - More code cleanup
>> - re-org the code per feedback
>> - Update to set context method
>> - add test cases
>> - Merge
>> - Update copyright year
>> - the object reference issue for Cleaner
>> - 8284490: Remove finalizer method in java.security.jgss
>
> test/jdk/sun/security/jgss/GssContextCleanup.java line 61:
>
>> 59: if (whm.size() > 0) {
>> 60: throw new RuntimeException("GSSContext object is not released");
>> 61: }
>
> I think it's necessary to check the debug message to make sure "[GSSLibStub_deleteContext]" is seen. This test should have already succeeded before your latest update to `NativeGSSContext`.
The same for `GSSName`. Where is a test for `GSSCredential`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8136
More information about the security-dev
mailing list