RFR: JDK-8285504 Minor cleanup could be done in javax.net [v2]

Bradford Wetmore wetmore at openjdk.java.net
Tue Apr 26 18:54:52 UTC 2022


On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers <duke at openjdk.java.net> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8285504
>> 
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for a single code review, so it was decided to split into smaller chunks. This is one such chunk: 
>> 
>> open/src/java.base/share/classes/java/net
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan Bateman comments

Other than the comments mentioned, LGTM.

src/java.base/share/classes/javax/net/ssl/SSLSessionBindingEvent.java line 37:

> 35:  * {@link SSLSession#putValue(String, Object)}
> 36:  * or {@link SSLSession#removeValue(String)}, objects which
> 37:  * implement the SSLSessionBindingListener will receive an

If you're up for it, you could fix the missing `<code></code>`  or `@link` throughout this small file.  Ignore otherwise.

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8384



More information about the security-dev mailing list