RFR: 8284910: Buffer clean in PasswordCallback [v6]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Wed Apr 27 15:29:42 UTC 2022


On Wed, 27 Apr 2022 13:44:14 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename and split the test case
>
> test/jdk/javax/security/auth/callback/PasswordCallback/PasswordCleanup.java line 55:
> 
>> 53:         }
>> 54: 
>> 55:         // Check if the PasswordCallback object could be collected.
> 
> Since you are already checking if the Cleaner works properly in the `CheckCleanerBound` test, I don't see a reason why you need to test that again.

It's a fair point.  Since the cleaner test is pretty slow, I'm going to remove that part in this test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8272



More information about the security-dev mailing list