RFR: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Wed Apr 27 15:40:44 UTC 2022


On Wed, 27 Apr 2022 14:03:15 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this follow up to #8349.
> 
> As JCK pointed out, `permits` is supposed to throw IAE on null input. However, now that we're looking up the result in a `ConcurrentHashMap`, a `NullPointerException` is thrown. This patch restores the original behavior.
> 
> Verified that the JCK test passes with this change.

Maybe, the checking could be placed in permits() method (line 158-173) so that it follows the spec, and easier to check.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8427



More information about the security-dev mailing list