RFR: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Wed Apr 27 16:22:42 UTC 2022


On Wed, 27 Apr 2022 16:16:18 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this follow up to #8349.
>> 
>> As JCK pointed out, `permits` is supposed to throw IAE on null input. However, now that we're looking up the result in a `ConcurrentHashMap`, a `NullPointerException` is thrown. This patch restores the original behavior.
>> 
>> Verified that the JCK test passes with this change.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move check to permits method

Looks good to me.  Thanks!

-------------

Marked as reviewed by xuelei (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8427


More information about the security-dev mailing list