RFR: 8284910: Buffer clean in PasswordCallback [v8]
Xue-Lei Andrew Fan
xuelei at openjdk.java.net
Wed Apr 27 16:22:39 UTC 2022
On Wed, 27 Apr 2022 16:02:04 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove trailing whitespace
>
> test/jdk/javax/security/auth/callback/PasswordCallback/CheckCleanerBound.java line 50:
>
>> 48: for (int i = 0; i < 10 && weakHashMap.size() != 0; i++) {
>> 49: System.gc();
>> 50: Thread.sleep(100);
>
> You can drop this sleep to 10ms to cut the average test time. It might be interesting to know how many retries are typical.
Hm, it looks like a good idea to improve the testing performance (code updated). The cleaner get called in the 1st GC collection on my local laptop.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8272
More information about the security-dev
mailing list