RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v2]

Valerie Peng valeriep at openjdk.java.net
Wed Apr 27 23:19:46 UTC 2022


On Wed, 27 Apr 2022 05:25:42 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Undo un-intentional changes.
>
> src/java.base/share/classes/java/security/Signature.java line 1012:
> 
>> 1010:      * values used by the underlying signature implementation if the underlying
>> 1011:      * signature implementation supports returning the parameters as
>> 1012:      * {@code AlgorithmParameters}. If the required
> 
> "... if the underlying signature implementation supports returning the parameters a {@code AlgorithmParameters}", it looks this part is duplicated and may be removed.

I am not sure which part duplicates the text that you quoted? The original text only mentions the supplied values. The proposed changes add that there may be additional parameters. Are you saying that these additional parameters are "implied" by the part that you quoted?

> What does it refer to with 'it'? Is 'it' refer to the implementation generated parameter values?

'It' refers to the parameters containing all of the parameter values including the supplied ones and provider-generated ones if any.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8396


More information about the security-dev mailing list