RFR: 8285785: CheckCleanerBound test fails with PasswordCallback object is not released

Daniel Fuchs dfuchs at openjdk.java.net
Thu Apr 28 08:35:41 UTC 2022


On Thu, 28 Apr 2022 07:01:25 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> Hi,
> 
> May I have this test update reviewed?
> 
> The javax/security/auth/callback/PasswordCallback/CheckCleanerBound.java test case failed on one of the test setups.  The test runs gc in a loop and expects the GC to have garbage collected contents of a WeakHashMap. The loop runs for 10 iterations. Some delay needs to be added between each iteration to increase the chances of GC garbage collecting the instances.
> 
> Thanks,
> Xuelei

LGTM. It's a bit strange to use a weak hash map for that though. It could be simpler to use `WeakReference<PasswordCalback>` and `ReferenceQueue`.

Marked as reviewed by dfuchs (Reviewer).

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8443


More information about the security-dev mailing list