RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v2]

Bradford Wetmore wetmore at openjdk.java.net
Fri Apr 29 01:50:39 UTC 2022


On Thu, 14 Apr 2022 15:37:05 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> IMO we should not send close_notify in the finalizer. It's the application's responsibility to send close_notify when it's done with the socket; we should not pretend that it was closed normally when it was not.

@djelinski makes an excellent point which I hadn't really considered.  This is an error situation.

As the native Socket resources are cleaned/released as needed, a simple removal might actually be appropriate.

@XueleiFan  I'm going to send you some internal discussion we've had in a minute.  Let's both parse it and see if there is anything further we should consider, and circle back tomorrow and finalize the plan & push.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8065



More information about the security-dev mailing list