RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v2]

Bradford Wetmore wetmore at openjdk.java.net
Sat Apr 30 03:40:43 UTC 2022


On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Please review the update to remove finalizer method in the SunJSSE provider implementation.  It is one of the efforts to clean up the use of finalizer method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - typo blank linke correction
>  - revise the update

Ok, after much back and forth, I'm convinced this is ok.  

@dfuch commented in another thread:

> An application should really close its sockets and not let them get garbage collected without closing them: this is sloppy.
> So brutally closing the underlying TCP connection in that case should be an acceptable behaviour, and that would be achieved by just removing the finalize. 

Thanks for allowing me to look more deeply into this.

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8065



More information about the security-dev mailing list