RFR: JDK-8290975 Minor cleanup could be done in javax.security

Bradford Wetmore wetmore at openjdk.org
Thu Aug 4 17:19:09 UTC 2022


On Wed, 27 Jul 2022 20:24:19 GMT, Mark Powers <mpowers at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8290975

LMGTM, don't need to rereview, but would appreciate comments on the import style you used.

src/java.base/share/classes/javax/security/auth/Subject.java line 36:

> 34: import java.security.*;
> 35: import java.text.MessageFormat;
> 36: import java.util.*;

What is the style convention you're trying to conform to here?

src/java.base/share/classes/javax/security/auth/Subject.java line 1230:

> 1228:                     if (sm != null) {
> 1229:                         switch (which) {
> 1230:                             case Subject.PRINCIPAL_SET:

The original style guide convention has the switch and case at the same level.  

https://www.oracle.com/technetwork/java/codeconventions-150003.pdf

Is this a reformat from IJ (Settings->Editor->Code Style->Java->Wrapping Braces->'switch statement'?  IIRC, this is one setting where the default value isn't what we used to do.

src/java.base/share/classes/javax/security/auth/spi/LoginModule.java line 29:

> 27: 
> 28: import javax.security.auth.Subject;
> 29: import javax.security.auth.callback.CallbackHandler;

Out of curiosity, did IJ point this out somehow?

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9664



More information about the security-dev mailing list