RFR: JDK-8290975 Minor cleanup could be done in javax.security

Bradford Wetmore wetmore at openjdk.org
Thu Aug 4 21:31:09 UTC 2022


On Thu, 4 Aug 2022 20:26:11 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/javax/security/auth/Subject.java line 36:
>> 
>>> 34: import java.security.*;
>>> 35: import java.text.MessageFormat;
>>> 36: import java.util.*;
>> 
>> What is the style convention you're trying to conform to here?
>
> I'm letting IJ optimize imports. I didn't see anything in the style guide.

Ah, I see it now.  Ctrl+Alt+O.  And you can configure from the Settings Import menu.

>> src/java.base/share/classes/javax/security/auth/spi/LoginModule.java line 29:
>> 
>>> 27: 
>>> 28: import javax.security.auth.Subject;
>>> 29: import javax.security.auth.callback.CallbackHandler;
>> 
>> Out of curiosity, did IJ point this out somehow?
>
> Yes. IJ complained about unused imports and offered to optimize them for me.

Ah, so this is where it asked if you wanted to optimize.

-------------

PR: https://git.openjdk.org/jdk/pull/9664


More information about the security-dev mailing list