RFR: JDK-8290975 Minor cleanup could be done in javax.security

[Bradford Wetmore]

On Thu, 4 Aug 2022 20:21:17 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/javax/security/auth/Subject.java line 28:
>> 
>>> 26: package javax.security.auth;
>>> 27: 
>>> 28: import sun.security.util.ResourcesMgr;
>> 
>> I suggest putting the internal imports below the java.*  or other standard imports. This isn't a rule, but is more consistent with other code.
>
> IJ complains about unnecessary imports and asks If I want to let it automatically optimize them. I always answer "yes". I'll fix as you suggest.

The default setup wants to put the sun.* imports above the java.*.  The default order is defined in "Import Layout":


all other imports
<blank line>
import javax.*
import java.*
<blank line>
import static all other imports


I have mine set to:


import java.*
import javax.*
<blank line>
all other imports
<blank line>
import static all other imports

-------------

PR: https://git.openjdk.org/jdk/pull/9664