RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v3]
Jayashree Huttanagoudar
duke at openjdk.org
Mon Aug 8 17:37:22 UTC 2022
On Mon, 8 Aug 2022 08:42:11 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:
> > BTW, have you reverted your change on `LoginContext.java`. I remembered we agreed that this bug is all about debug info instead of updating the exception thrown.
>
> Actually here: https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug , the ask is that its better to print the stack trace of an exception so I didn't revert it back. And sorry I didn't mention that in the conversation. Already the `debug.println` is there for `OPTIONAL` section here: https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/javax/security/auth/login/LoginContext.java#L880 where `debug!=null`.
I have reverted my changes to LoginContext.java. I verified that, the change I added wasn't making any difference with the test case I wrote using {Unix,NT}LoginModule.
Further, I am not sure which could be the right place to add logging information to help developer understand the failure reason of an optional JAAS LoginModule.
-------------
PR: https://git.openjdk.org/jdk/pull/9159
More information about the security-dev
mailing list