RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v4]

Julian Waters jwaters at openjdk.org
Sun Aug 14 06:39:58 UTC 2022


> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which is actually 1 on Windows, not -1. Can be safely commented out as it isn't used anywhere, except for in a call to ExitProcess which has also been commented out as well.

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into patch-2
 - Merge branch 'openjdk:master' into patch-2
 - Merge branch 'openjdk:master' into patch-2
 - Comment out EXIT_FAILURE redefinition

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9678/files
  - new: https://git.openjdk.org/jdk/pull/9678/files/76e0a33d..55434243

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9678&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9678&range=02-03

  Stats: 8200 lines in 328 files changed: 4166 ins; 2257 del; 1777 mod
  Patch: https://git.openjdk.org/jdk/pull/9678.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9678/head:pull/9678

PR: https://git.openjdk.org/jdk/pull/9678



More information about the security-dev mailing list