RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v4]

Julian Waters jwaters at openjdk.org
Mon Aug 15 14:13:15 UTC 2022


On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which is actually 1 on Windows, not -1. Can be safely commented out as it isn't used anywhere, except for in a call to ExitProcess which has also been commented out as well.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Comment out EXIT_FAILURE redefinition

I did contemplate doing so, but I think it may have been commented out instead of being completely removed for a reason, do we really not need it anymore?

-------------

PR: https://git.openjdk.org/jdk/pull/9678


More information about the security-dev mailing list