RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v5]

Julian Waters jwaters at openjdk.org
Mon Aug 15 16:17:42 UTC 2022


> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which is actually 1 on Windows, not -1. Can be safely commented out as it isn't used anywhere, except for in a call to ExitProcess which has also been commented out as well.

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'openjdk:master' into patch-2
 - Move commented define next to commented out ExitProcess call
 - Merge branch 'openjdk:master' into patch-2
 - Merge branch 'openjdk:master' into patch-2
 - Merge branch 'openjdk:master' into patch-2
 - Comment out EXIT_FAILURE redefinition

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9678/files
  - new: https://git.openjdk.org/jdk/pull/9678/files/55434243..ac7e7e55

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9678&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9678&range=03-04

  Stats: 1056 lines in 61 files changed: 678 ins; 307 del; 71 mod
  Patch: https://git.openjdk.org/jdk/pull/9678.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9678/head:pull/9678

PR: https://git.openjdk.org/jdk/pull/9678


More information about the security-dev mailing list