Integrated: 8290775: Some doc errors in DerOutputStream.java

jquanC duke at openjdk.org
Tue Aug 16 14:49:25 UTC 2022


On Thu, 21 Jul 2022 08:53:31 GMT, jquanC <duke at openjdk.org> wrote:

> There are some doc errors in sun.security.util.DerOutputStream, like the followings,
> 
> 
> /**
>  * Private helper routine for writing DER encoded string values.
>  * @param s the string to write
>  * @param stringTag one of the DER string tags that indicate which
>  * encoding should be used to write the string out.
>  * @param enc the name of the encoder that should be used corresponding
>  * to the above tag.
>  */
> private void writeString(String s, byte stringTag, Charset charset) throws IOException
> 
> The parameter is charset, but not enc.
> 
> 
> /**
>  * Marshals a DER integer on the output stream.
>  *
>  * @param i the integer in bytes, equivalent to BigInteger::toByteArray.
>  */
> public void putInteger(byte[] buf) throws IOException {
> 
> The parameter is buf, but not i.

This pull request has now been integrated.

Changeset: 3e122419
Author:    jquanC <jack_cai.sh at foxmail.com>
Committer: Weijun Wang <weijun at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3e122419b2979235f57c0dd549ca63647ea73753
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

8290775: Some doc errors in DerOutputStream.java

Reviewed-by: xuelei

-------------

PR: https://git.openjdk.org/jdk/pull/9585



More information about the security-dev mailing list