RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v11]

Weijun Wang weijun at openjdk.org
Wed Aug 17 17:36:28 UTC 2022


On Wed, 17 Aug 2022 12:50:37 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:

>> Could you please review the changes?
>> This patch is to address : https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address whitespace error by jcheck

src/java.base/share/classes/javax/security/auth/login/LoginContext.java line 883:

> 881:                         debug.println(methodName + " OPTIONAL failure");
> 882: 
> 883:                     le.printStackTrace();

This line should only be called when `debug != null`.

test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java line 85:

> 83:         byte[] byes = stream.toByteArray();
> 84:         String s = new String(byes);
> 85:         System.out.printf("-- error -- %n%s%n", s);

The test should ensure the stack trace is included in the debug output. Please check the content of `s`. Make sure this test succeeds after the code change and fails before it.

-------------

PR: https://git.openjdk.org/jdk/pull/9159


More information about the security-dev mailing list