RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v16]

Jayashree Huttanagoudar duke at openjdk.org
Mon Aug 22 08:39:00 UTC 2022


On Fri, 19 Aug 2022 21:47:00 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java line 85:
> 
>> 83:            throw new RuntimeException();
>> 84:         } else {
>> 85:            System.out.printf("-- call stack is -- %n%s%n", s);
> 
> I'd rather print out the call stack if the test fails. Who would want to read the test output if it succeeds?

Aim of this patch is to print the call stack trace right ? And if the test case passes that means we have to print the call stack trace.
And if the test case fails are suggesting to print the exception we are throwing (i.e RuntimeException) ?

-------------

PR: https://git.openjdk.org/jdk/pull/9159



More information about the security-dev mailing list