RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v17]

[Weijun Wang]

On Mon, 22 Aug 2022 14:56:34 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:

>> Could you please review the changes?
>> This patch is to address : https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

The new `setErr` is good. 

You still haven't printed out the stack trace when the test fails. I know this has not effect on whether the test fails or not. The benefit of it is for diagnosis once the test fails. Has I seen a failure, the 1st thing I would do is to look into the stack trace and see why that message is not there. So, why not add it now?

Another comment: the 2 constants defined at the beginning of the test are useless now. You can remove them.

-------------

PR: https://git.openjdk.org/jdk/pull/9159