RFR: 8215916: The failure reason of an optional JAAS LoginModule is not logged [v18]

Weijun Wang weijun at openjdk.org
Mon Aug 22 17:44:38 UTC 2022


On Mon, 22 Aug 2022 17:08:09 GMT, Jayashree Huttanagoudar <duke at openjdk.org> wrote:

> So the patch should look like :
> ...

Yes. If you decide to print out `s` no matter if success or not, you can move it out of the if block.

> I tried to execute the test case with this change and I don't see anything changed much.

Of course not. It would be useful if the test fails one day. For example, you can try to modify the exception message on line 150 of `NTLoginModule` and see how the test fails.

-------------

PR: https://git.openjdk.org/jdk/pull/9159



More information about the security-dev mailing list