RFR: 8276660: Scalability bottleneck in java.security.Provider.getService() [v6]

[Josef Eisl]

On Fri, 19 Aug 2022 23:32:17 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> src/java.base/share/classes/java/security/Provider.java line 1276:
>> 
>>> 1274:         }
>>> 1275:         if (serviceSet == null) {
>>> 1276:             ensureLegacyParsed();
>> 
>> Hi @valeriepeng! I believe that with this change, `getServices()` will return invalid legacy services. Before we called `ensureLegacyParsed()`, which eventually called `removeInvalidServices()`. In `getService(String, String)`, we are now explicitly checking for `isValid()` to keep the old behavior. Shouldn't we do something similar here as well? Am I missing something or is this an intended change?
>
> Hmm, could be. Let me check into it and I will have to file a separate bug to address this since the changes have already been integrated. Thanks for the comments.

Thanks for looking into this! Please let me if you open a new bug so we can track it.

-------------

PR: https://git.openjdk.org/jdk/pull/6513