RFR: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified [v5]

Valerie Peng valeriep at openjdk.org
Tue Aug 23 23:59:31 UTC 2022


On Tue, 23 Aug 2022 23:34:27 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> add @exception message to indicate an NPE might be thrown when the input parameter is null
>
> Kevin Driver has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - move test
>  - new test for MacSpi demo purposes

test/jdk/com/sun/crypto/provider/Mac/Test6205692.java line 112:

> 110:         }
> 111:     }
> 112: }

Can remove all these and directly instantiate the dummy MacSpi object and call the public engineUpdate(ByteBuffer) method in the execute method.

-------------

PR: https://git.openjdk.org/jdk/pull/9859


More information about the security-dev mailing list