RFR: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified [v6]
Bradford Wetmore
wetmore at openjdk.org
Wed Aug 24 00:43:34 UTC 2022
On Wed, 24 Aug 2022 00:19:50 GMT, Kevin Driver <kdriver at openjdk.org> wrote:
>> add @exception message to indicate an NPE might be thrown when the input parameter is null
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>
> remove unnecessary code
Minor nits, don't need to be rereviewed after fixing.
test/jdk/com/sun/crypto/provider/Mac/Test6205692.java line 33:
> 31: import jdk.test.lib.Utils;
> 32:
> 33: import javax.crypto.Mac;
Mac and Provider no longer needed.
test/jdk/com/sun/crypto/provider/Mac/Test6205692.java line 79:
> 77:
> 78: @Override
> 79: protected void engineInit(Key key, AlgorithmParameterSpec params) throws InvalidKeyException, InvalidAlgorithmParameterException {
More than 80 chars
-------------
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9859
More information about the security-dev
mailing list