RFR: 8292681: Add JMH for ProtectionDomain [v2]

[Eric Caspole]

On Wed, 24 Aug 2022 05:35:54 GMT, David Schlosnagle <duke at openjdk.org> wrote:

>> Eric Caspole has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates from reviewers comments
>
> test/micro/org/openjdk/bench/java/security/ProtectionDomainBench.java line 49:
> 
>> 47: @OutputTimeUnit(TimeUnit.MILLISECONDS)
>> 48: @Warmup(iterations = 15)
>> 49: @Measurement(iterations = 15)
> 
> Given the recent work to reduce microbenchmark runtimes, does this actually need this many iterations and time to get a stable microbenchmark?

You are right, I changed it back to throughput mode and 5/2. Also the main work is in the Setup and it can be done per Trial, not per Iteration.

> test/micro/org/openjdk/bench/java/security/ProtectionDomainBench.java line 73:
> 
>> 71:                 + "       intField++;"
>> 72:                 + "   }"
>> 73:                 + "}");
> 
> Curious why copying to new String? Is this to try to avoid string deduplication? Could it be simplified?
> 
> Suggestion:
> 
>         return "public class B" + count + " {"
>                 + "   static int intField;"
>                 + "   public static void compiledMethod() { "
>                 + "       intField++;"
>                 + "   }"
>                 + "}";

I agree on this, chnaged.

-------------

PR: https://git.openjdk.org/jdk/pull/9950